search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.99k stars 1.18k forks source link

[Bug] Import-button creates a probably unnecessary huge DOM element #8167

Open pmario opened 5 months ago

pmario commented 5 months ago

While messing with the transclusion detection I did find this one.

The cause is the import-button font-size is 999px, which was introduced 10 years ago. See: https://github.com/Jermolene/TiddlyWiki5/commit/7816c1d944dd92a1ff83210d82357154d646e1c5

@Jermolene Can you remember why it was set that way. If I remove that value from the stylesheet, the DOM seems to be fixed

See rigth sidebar -> tools -- I'm using the Edge browser to see the DOM levels.

image

Jermolene commented 5 months ago

Hi @pmario the approach TW uses for styling file inputs was standard stuff in 2013. I found a few references to it, but not sure which one I used back then:

https://l33tsource.com/blog/2013/07/21/Fancy-File-Upload-Buttons/

There may well be better options now that we don't need to worry about Internet Explorer etc.