search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.98k stars 1.18k forks source link

Fix invalid accept header in put saver #8547

Closed simonbaird closed 1 week ago

simonbaird commented 3 weeks ago

IIUC the charset doesn't belong in the Accept header. It does belong in a Content-Type header though, see [1] and [2].

FYI this header causes problems for Tiddlyhost which must work around the invalid mime type, see [3] for the nitty-gritty.

[1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept [2] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type [3] https://github.com/simonbaird/tiddlyhost/commit/10cd3535529adf9ec1241ab8cd639ba1a2abb16f

github-actions[bot] commented 3 weeks ago

Confirmed: simonbaird has already signed the Contributor License Agreement (see contributing.md)

Jermolene commented 1 week ago

Thanks @simonbaird and apologies for the delay