TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.98k stars 1.18k forks source link

Add empty message to tag picker, search dropdown and advanced search #8558

Closed Leilei332 closed 2 weeks ago

Leilei332 commented 2 weeks ago

Implement feature described in #8343 and closes #8343 .

The count widget in $:/core/ui/AdvancedSearch/Shadows and $:/core/ui/AdvancedSearch/System is replaced by the count filter operator to let the conditional shortcut work.

github-actions[bot] commented 2 weeks ago

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

Leilei332 commented 2 weeks ago

Since the Standard page in advanced search is implemented in a strange way and exists a problem (see #8485 ), adding empty message to it will be postponed.

pmario commented 2 weeks ago

Since the Standard page in advanced search is implemented in a strange way and exists a problem (see https://github.com/TiddlyWiki/TiddlyWiki5/pull/8485 ), adding empty message to it will be postponed.

If you want to postpone #8485 you should make it a draft too.

Leilei332 commented 2 weeks ago

Actually #8485 is ready to be merged now. I intended to add empty message to the Standard tab after it is merged.

Jermolene commented 2 weeks ago

Thanks @Leilei332 looks good

Jermolene commented 2 weeks ago

Thanks @Leilei332