search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.98k stars 1.18k forks source link

Add a settings page for markdown plugin #8585

Closed Leilei332 closed 6 days ago

Leilei332 commented 1 week ago

The table in $:/plugins/tiddlywiki/markdown/config isn't convenient to edit configuations for markdown plugin, and it also causes the page to overflow in mobile devices.

This PR add a settings page for markdown plugin under the "Settings" tab in control panel, which is convenient to edit settings. It also removes the overflowed table in $:/plugins/tiddlywiki/markdown/config.

stackblitz[bot] commented 1 week ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-actions[bot] commented 1 week ago

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

pmario commented 1 week ago

It looks good. But I would move the "Quotes replacement" section below the "Typographer" toggle. Quotes depends on Typo- So they should be together

image

pmario commented 1 week ago

There should also be a link to eg:

For more information see the plugin "readme and config" tab -- (Using TW wiki-links )

pmario commented 1 week ago

If we have settings. Imo config is redundant

Leilei332 commented 1 week ago

If we have settings. Imo config is redundant

IMO the contents in the config tab can be moved to the readme tab.

Jermolene commented 1 week ago

IMO the contents in the config tab can be moved to the readme tab.

I think that's a good idea @Leilei332

Jermolene commented 6 days ago

Hi @Leilei332 I'm going to merge this now, we can always come back to moving the config tab content into the readme tab.