search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.08k stars 1.19k forks source link

Fix $:/temp/advancedsearch displayed in Shadow search #8723

Closed Leilei332 closed 2 weeks ago

Leilei332 commented 2 weeks ago

Fix the problem introduced in #8678.

图片

github-actions[bot] commented 2 weeks ago

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

Leilei332 commented 2 weeks ago

Actually I wonder whether we should use - for convenience or :except for readability here.

pmario commented 2 weeks ago

Actually I wonder whether we should use - for convenience or :except for readability here

In the core verbosity is preferable. So it's easier to understand if users want to modify it. So I think it's OK the way you did it.

BurningTreeC commented 2 weeks ago

Hi all, so sorry about this mistake! Thanks @Leilei332 for spotting this bug!

Jermolene commented 2 weeks ago

Thanks @Leilei332

Actually I wonder whether we should use - for convenience or :except for readability here

In the core verbosity is preferable. So it's easier to understand if users want to modify it. So I think it's OK the way you did it.

Yes indeed. We might prefer to say "clarity" than "verbosity"