search

TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
8.07k stars 1.19k forks source link

[BUG] Tiddler Title area DOM elements can be optimized #8742

Open pmario opened 1 week ago

pmario commented 1 week ago

Describe the bug

The tiddler title area contains several reveal-widget-DIVs, where the first child also is a DIV. The child DIV is redundant.

  1. DIV artefact from the "tiddler fold state" -> IMO this one should use <%if %>, so go away. Only show it when needed.
  2. The subtitle reveal can stay, but can get new classes: class="tc-subtitle tc-clearfix" -> So redundant child can go away
  3. Same as 2. but with tc-tag-wrapper

grafik

Expected behavior

Redundant child widgets should be gone.

TiddlyWiki Configuration

v5.3.5 v5.3.6-pre

Jermolene commented 1 week ago

Hi @pmario while it is frustrating that we have those additional elements, I don't think it is worth the risk of making a change if there is no other user benefit apart from the simplification. So, for example, this might be something to fix at the same time as providing a UI to allow users to disable and reorder the tiddler segments.

pmario commented 1 week ago

The problem is only there with the new test-case templates. So there should be no side effects to other elements.

Jermolene commented 1 week ago

Hi @pmario the OP doesn't mention the testcase widget or testcase templates

pmario commented 1 week ago

uuups. I did respond with the wrong issue in mind. Sorry. My response was targeted to [BUG] testcase-widget produces redundant HMTL tags: P DIV DIV P #8741

Jermolene commented 1 week ago

Thanks @pmario that makes sense, no worries.