TiddlyWiki / TiddlyWiki5

A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.
https://tiddlywiki.com/
Other
7.97k stars 1.18k forks source link

Avoid rendering certain system tiddlers in story view #919

Closed Eucaly closed 1 year ago

Eucaly commented 9 years ago

That might include below system tiddlers (at least) $:/core/ui/PageTemplate $:/core/ui/ViewTemplate $:/core/save/all $:/core/save/empty $:/core/save/lazy-images $:/core/templates/static.content $:/core/templates/store.area.template.html

source: https://groups.google.com/forum/#!topic/tiddlywikidev/9uN1y7hpQgw

Jermolene commented 9 years ago

I've added a comment back in the Google Groups thread:

I'm not convinced that it's a problem that the transclusion recursion error appears when viewing tiddlers like the PageTemplate. All of the tiddlers listed are pretty advanced artefacts of the heart of TiddlyWiki; there's little that a casual user might understand. I guess the concern is that they would see the word "error" and panic that something is broken?

It strikes me that the explanation for the transclusion recursion error is actually quite instructive, giving people an insight into how TW works. We could improve the error message to include a link to tiddlywiki.com that explains what's going on.

I'm very against introducing a system tag; we already have a convention for identifying system tiddlers, and adding a second one would lead to confusion. But of course we could implement your suggestion with a specific list of tiddler titles that should be displayed differently.

One further thought: we could add an attribute to the transclude widget that provides a custom error message. Then the page template could include a clearer error message that reassures the user that nothing is wrong.

pmario commented 7 years ago

fix is on the way: http://tiddlywiki.com/prerelease/ ... after quite some time :)

tobibeer commented 6 years ago

@pmario: Where's that?

pmario commented 6 years ago

IMO has been removed again. Had to many side effects.

pmario commented 1 year ago

The new ViewTemplate cascade handling shows those core tiddlers as code

[prefix[$:/boot/]] [prefix[$:/config/]] [prefix[$:/core/macros]] [prefix[$:/core/save/]] [prefix[$:/core/templates/]] 
[prefix[$:/core/ui/]split[/]count[]compare:number:eq[4]] [prefix[$:/info/]] [prefix[$:/language/]] [prefix[$:/languages/]]
[prefix[$:/snippets/]] [prefix[$:/state/]] [prefix[$:/status/]] [prefix[$:/info/]] [prefix[$:/temp/]] 
+[!is[image]limit[1]then[$:/core/ui/ViewTemplate/body/code]]

@Jermolene ... IMO can be closed

Jermolene commented 1 year ago

Thanks @pmario