search

TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
493 stars 114 forks source link

Fixing upgrading: URI to get the core from #212

Closed YakovL closed 6 years ago

YakovL commented 6 years ago

Currently, the upgrade URL is set to unexisting http://tiddlywiki-releases.tiddlyspace.com/upgrade This first set of upgrading fixes changes that to http://classic.tiddlywiki.com/upgrade/ and also introduces an option which can be used to set a custom path to load core from when upgrading (including a local path)

This allows to do upgrading from a local file and also is necessary to make upgrading from repo work again.

Feel free to suggest a better option description, if you can think of one.

YakovL commented 6 years ago

Hi @Jermolene , recently I've tried accessing classic.tiddlywiki.com by https and failed, but now I can see that everything's alright, could you provide some details on this? Github (pages) settings panel told me there was something wrong about SSL certificate, and in terms of maintaining I wonder if it's reliable to set the default url to https://classic.tiddlywiki.com/upgrade/ instead (the http version was available at the described time)

Jermolene commented 6 years ago

Hi @YakovL I've just had a look at the settings for https://github.com/TiddlyWiki/tiddlywiki.github.com/settings and "Enforce HTTPS" was not checked; I've now checked it, which is what we do on the main https://tiddlywiki.com site. So yes, I think it makes sense to update the update URL to SSL too.

By the way, Chrome doesn't show a green address bar for https://classic.tiddlywiki.com/ because we've got images loaded over http...

Jermolene commented 6 years ago

By the way @YakovL I wanted to congratulate you on your progress with TiddlyWiki Classic, it is an absolute pleasure to see things moving on, and I think will be very much appreciated by the loyal TWC user base.

YakovL commented 6 years ago

Hi Jeremy, thanks for pointing the problem with the pictures, I'll fix that at some point, along with broken images and other stuff. By the way, who owns the Flattr account? (one of the images is from that widget) I'm not sure if it even operates properly and also if I can remove it or may be substitute with some donation method if anybody is willing to support further development.