TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
493 stars 114 forks source link

Fix up recent changes in docs and update links to TiddlyTools #245

Closed YakovL closed 5 years ago

YakovL commented 5 years ago

Hi @markkerrigan , I've updated classic.tiddlywiki.com yesterday after committing fixes with this PR. What I'd like to note are 2 things:

This is something to be mentioned in documentation contribution guidelines, I guess

markkerrigan commented 5 years ago

Hi Yakov

Thanks for the info, I didn't think about that, but I put that down in my notes for the documentation process.

One thing I wanted to point out and I suppose it is relevant to our previous discussions about what heading level to use is the size differences between h1 and the title of the tiddler are seemingly too similar. Only a difference of .25 em, which doesn't quite look right.

h1-size-difference

I think this is more of a problem with how the tiddler title and heading are styled being too similar in both size and color, and less about the choice to use h1 over h3. I don't have a problem using h1, but I find it's an interesting problem. Notably if you look in TiddlyWiki Browser Compatibility, you can also see Jeremy also used h3 within a tiddler.

I also realized I put in extra line breaks before the headings. Usually I don't put in those extra line breaks, but due to the fact I'm editing these .tid files in Sublime Text, I don't immediately see the output of how it would look on TiddlyWiki. So I'll change those in my next pull request.

YakovL commented 5 years ago

Hi Mark, exactly same thoughts about headers (noticed when reviewing [[Documentation]], too).

I'm also going to move the cross svg icon used currently in the message area into some accessible part of code so that it can be reused and then we can update SimpleSearchPlugin so that its search results uses it instead of the ugly "close" button. I'll mention that in the google group thread, just haven't found time to read and reply there thoroughly yet. The good thing about the site is we can change styles there more boldly unlike the TWC core which requires caring about backward compability.