search

TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
492 stars 114 forks source link

release 2.9.3 #274

Closed YakovL closed 2 years ago

YakovL commented 2 years ago

This PR is created to encourage release of 2.9.3. Main todos before release:

Pre-releasing:

After this is merged:

After the release:

Things that I would like to add to the release very much, but better go to the next one:

YakovL commented 2 years ago

Here's the full changelog that may be summarized in the release:

YakovL commented 2 years ago

A plugin for auto-checking upgrades preview:

/***
Installation of this plugin is standart: create tiddler, paste this as text, tag with systemConfig, save, reload
|Source|http://yakovlitvin.pro/TW/pre-releases/SimplifiedUpgradingPlugin.txt|
|Author|Yakov Litvin|
***/
//{{{
config.macros.upgrade.extractVersion = function(upgradeFile)
{
    var re = /version = \{\s*title: "([^"]+)", major: (\d+), minor: (\d+), revision: (\d+)(, beta: (\d+)){0,1}, date: new Date\("([^"]+)"\)/mg;
    var m = re.exec(upgradeFile);
    return !m ? null : {
        title: m[1], major: m[2], minor: m[3], revision: m[4], beta: m[6], date: new Date(m[7])
    }
};

config.macros.upgrade.loadLatestCore = function(onSuccess, onError) {
    ajaxReq({
        type: "GET",
        url: this.getSourceURL(),
        processData: false,
        success: onSuccess,
        error: onError
    });
};

config.macros.upgrade.init = function()
{
    // in the next TW release, upgrade autocheck will be the default behavior with an option to disable it;
    // it will load a small meta file instead of the whole core
    this.loadLatestCore(function(coreAsText) {
        var availableVersion = this.extractVersion(coreAsText);
        if(compareVersions(version, availableVersion) !== 1) return;
        displayMessage("An upgrade to TiddlyWiki v" + formatVersion(availableVersion) + " is available");
    })
}
//}}}

Its updated version will be added in the next release as a part of the core.

YakovL commented 2 years ago

Here's the changes summary for announcements:

see full changelog here: https://github.com/TiddlyWiki/TiddlyWiki/pull/274#issuecomment-1166461319

qbroker commented 2 years ago

Regarding the upgrade autocheck. My opinion is that it should be disabled by default, if you want to connect to a third source you have to do this actively and not as default.

YakovL commented 2 years ago

@qbroker could you add some arguments to your opinion (about the upgrade autocheck)?

qbroker commented 2 years ago

@qbroker could you add some arguments to your opinion (about the upgrade autocheck)?

@Yakov, I think that TiddlyWiki Classic should be an example of privacy by design. Privacy should be embedded in the design and should not be an option that user must switch on/off after events have occurred. The design of TWC must be such that privacy invasive events, like contacting the internet automatically, also at first start up, are avoided. In case of an autoCheck-Plugin that is on by default the user shares information on the internet, the only thing he can do is a reactive measure and switch the plugin off. Privacy must be the choice of the individual user, if the user likes the autoCheck-Plugin functionality he must actively switch it on.

Have a nice day, Okido

YakovL commented 2 years ago

Right, I see your point. I think we'll stick to the plugin version of autocheck for some time and the version that'll go to the core should a) be off by default and b) provide some "ask once" dialogue so that users can explore it without reading changelogs

qbroker commented 2 years ago

Very good Yakov, thanks.

KarelWintersky commented 2 years ago

@YakovL иного способа сохранять tiddlywiki кроме как "сохранить файл, записать поверх, нажать Ctrl-F5" в нашей реальности нет?

YakovL commented 2 years ago

@KarelWintersky есть, и не один, включая на Android и даже iOS: https://classic.tiddlywiki.com/#%5B%5BSetting%20up%20saving%5D%5D

Но конкретно с обновлением пока всё не очень здорово: https://groups.google.com/g/tiddlywikiclassic/c/BRiZ6uLV9yQ/m/OKMAgBpAAwAJ

Помнится, ты писал, что тебе удобнее обсуждать в Тг, могу сделать группу, если скинешь ник (точнее, могу сделать одну, предполагая её англоязычной, или две, если хочется русскоязычную)

KarelWintersky commented 2 years ago

Помнится, ты писал, что тебе удобнее обсуждать в Тг

Вполне возможно, хотя я совершенно этого не помню :-) Наверное было давно ;-)

А мой ник очевиден ;-) Совпадает с именем аккаунта здесь ;-)

Кстати, можно было бы создать и дискорд-сервер :) Там же можно и каналы плодить под одной крышей, и всякое такое.