search

TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
492 stars 114 forks source link

missing message tm-close-external-window #276

Closed Skeeve closed 1 year ago

Skeeve commented 1 year ago

We have

but no tm-close-external-window and you cannot use tm-close-window to close an external one because tm-open-external-window accepts no window_id required for closing.

Jermolene commented 1 year ago

Hi @Skeeve, good to see you!

Adding tm-close-external-window would indeed make sense, thank you

Skeeve commented 1 year ago

Hi @Jermolene. It's quite difficult to get used to TW5 again after such a long time not using it.

Jermolene commented 1 year ago

Hi @Skeeve as ever, please do share any thoughts – I hope you'll enjoy the new features.

Skeeve commented 1 year ago

Currently I'm doing it like this:

  1. tm-close-window with a given ID
  2. tm-open-window with same ID
  3. tm-open-external-window with name "external-" + ID

1 makes sure I close it should it be open 2 opens a new window showing a "Standby..." Tiddler 3 opens the external URL I want to show in athe very same window

Additionally steps 1, 2, and 3 make sure the window gets the focus. Very important on mobile devices.

YakovL commented 1 year ago

Closing this as a TW5-related issue. Hope that all the context is already moved or settled. Otherwise, please open an issue in the TW5 repo.