Utilities formatVersion include nightly

[qbroker]

To avoid mistakes the nightly build version should be expressed in the version output. Consider if nightly version check is required in the update functions.

[qbroker]

Hi Yakov,

Please forget the 449d46e commit.

Okido

[YakovL]

Looks reasonable, thanks!

To me, it seems that upgrading shouldn't be affected by nightly versions at all, since one only can upgrade (and should only try so) if they know what they're doing (nightly builds are not supposed to be served on the main site, and using upgrade feature is only possible with some via some customization). Do you have some specific scenario in mind?

[YakovL]

Note for myself: may be refactor/fix to

{
    v = v || version;
    var label = v.nightly ? "nightly " + v.nightly :
        v.alpha ? "alpha " + v.alpha :
        v.beta ? "beta " + v.beta :
        "";
    return v.major + "." + v.minor + "." + v.revision +
        (label ? " (" + label + ")" : "");
}

[YakovL]

Note for myself: may be refactor/fix to

{
    v = v || version;
    var label = v.nightly ? "nightly " + v.nightly :
        v.alpha ? "alpha " + v.alpha :
        v.beta ? "beta " + v.beta :
        "";
    return v.major + "." + v.minor + "." + v.revision +
        (label ? " (" + label + ")" : "");
}

[qbroker]

Hello Yakov,

You are right that upgrading shouldn't be affected by nightly versions at all. I had no specific scenario in mind.

Thanks, Okido