search

TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
494 stars 114 forks source link

css: fix missing color palette reference #297

Closed PengjuYan closed 9 months ago

PengjuYan commented 9 months ago

Some color in ColorPalette do not appear in some css fragments where they should do. It doesn't have any consequence if you use the original ColorPalette. However, if you try to make your own ColorPalette, e.g., your own dark mode (other than Yakov Litvin's DarkModePlugin), you'll find some colors don't change as you expected.

  1. Here's a snapshot of what's my own dark mode color palette will exhibit in view mode, which is as expected: 20240125-114427
  2. Here in edit mode, which is not as expected: 20240125-114441
  3. Here it appears as what we want after the fix: 20240125-114454
PengjuYan commented 9 months ago

Sorry, let me fix my name and email address and send another pull request.

BTW: Is it possible for me to recall this PR? (This is my first PR.)

YakovL commented 9 months ago

Hi @PengjuYan, thanks for your contribution! I'll review #298 and comment there. You have correctly closed the PR, so no problem with that.