TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
492 stars 114 forks source link

Fix favicon #300

Open markkerrigan opened 7 months ago

markkerrigan commented 7 months ago

It looks like for whatever reason, MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com

Also it's unsure if the favicon.ico tid is needed as this ends up generating links to nonexisting tiddlers.

It might also be a good idea to write a quick description about how to add a favicon.

YakovL commented 7 months ago

Hello Mark, thanks for pointing, I've included the first 2 issues into the plan of 2.10.1 (see #299).

As for the last part, let me start from a short draft here:

Todo:

YakovL commented 7 months ago

Alright, [[favicon.ico]] is removed (0dac50d); indeed,

MarkupPreHead isn't making it into the built versions of classic.tiddlywiki.com

is correct, the current build procedure ignores those bits (markup blocks, page title, etc). I'll take a closer look later. For now, I've just manually fixed the favicon on the site by an additional commit (https://github.com/TiddlyWiki/tiddlywiki.github.com/commit/5a8384c2e159fb8c0d4af70c1b1a7b3e7f2cf40d).