search

TiddlyWiki / TiddlyWikiClassic

TiddlyWiki Classic (not to be confused with TiddlyWiki5: https://github.com/Jermolene/TiddlyWiki5)
https://classic.tiddlywiki.com/
492 stars 114 forks source link

MathSVGPlugin broken after upgrade to 2.10.1 #305

Closed PengjuYan closed 7 months ago

PengjuYan commented 7 months ago

I upgraded to 2.10.1 but found that my MathSVGPlugin just doesn't work any longer.

Reproduction details:

  1. My previous TiddlyWiki version: 2.10.0;
  2. My MathSVGPlugin version: 1.3.3 (though we can get it from the official site any more, a user's demonstration site contains it);
  3. My browser is Firefox 122.0.1 (on macOS 13.0.1);
  4. After upgrading and reloading, PluginManager reports: Error: TypeError: $.browser is undefined on the row of MathSVGPlugin.
PengjuYan commented 7 months ago

Math is an important part of my daily TiddlyWiki life. It'll be very much appreciated if it is fixed in the later releases.

PS: I'm aware of the TwFormulaePlugin, however I just didn't make it work on my environment the other day. Will try it again some days later.

YakovL commented 7 months ago

Hi Pengju, yes, I've faced this issue with one of my older plugins, this is because of jQuery update (1.8.3 → 1.9.1): jQuery.browser was removed there. I'm not sure if we really need to add this (long deprecated) functionality back, but as a workaround, you can try substituting the $.browser.mozilla and $.browser.opera bits with just false (they were used to detect some differences between old browsers). In the worst case, you may need to substitute $.browser.mozilla with true and $.browser.opera with false, but I doubt that.

PS And yes, I'd encourage to try TwFormulaePlugin, I can help with it if needed.

PengjuYan commented 7 months ago

Thank you Yakov. I agree that we don't need to invest much time on backward compatibility to old plugins.

I created a new GoogleGroup topic here to track the support of TwFormulaePlugin: Asking help for TwFormulaePlugin, just in case others are interested.