Closed retostauss closed 1 year ago
Hi Reto, great! You have successfully made an edit and a PR, now let's make it mergeable:
action: saveChanges
(to keep backwards compatibility with versions below 2.6.3) or remove the , action: saveChanges
bit;Some explanations regarding the slices:
Feel free to use the minimal approach for now, to get confident about the updating process first.
Another note: to do more commits to this PR, you just need to:
translate-264
, https://github.com/retostauss/translations/tree/translate-264);OMG, Yakov, you are so incredibly patient and helpful - your huge extra effort to describe everything in this detail is my motivation for now ;-)
I followed the steps, hope it fits now.
Great! One last bit: since you have removed the action: saveChanges
bit, the translation will break the "save" button in backstage before 2.6.3, so it's better to keep the ~CoreVersion
slice, but set it to 2.6.3
. On the other hand, there's hardly a user who uses TW below 2.6.3, so I'll merge this PR and you can add ~CoreVersion
in the next PR if you like.
Thanks! Would be lovely if you go on with this to update the translation to later versions. Now, as you've made an update to your master
branch that's not merged yet, I suggest to either continue with updates in the translate-264
branch (after merging, they will no longer come to this PR, you'll need a new one) or create another branch from translate-264
(not from master) – you can specify that in the new branch UI:
Once we finish and merge the other PR, you'll be able to make new branches from master
again, without them having unwanted commits (unwanted in the sense "changes that are logically different should be separated into different PRs")
It is my intention to update the German translation to the current TWc version - to get more practice. And I will add again ~CoreVersion
in the next PR.
Just to try the suggested steps in the TiddlyWikiClassic Google group ...