TidierOrg / TidierData.jl

Tidier data transformations in Julia, modeled after the dplyr/tidyr R packages.
MIT License
86 stars 7 forks source link

Fix docs for `@slices_sample(5)` #98

Closed GlenHertz closed 4 months ago

GlenHertz commented 6 months ago

@slices_sample(5) doesn't create 5 samples (need @slices_sample(n=5) instead. Perhaps this is a coding issue (not a doc issue).

kdpsingh commented 6 months ago

Thank you so much! Let me look at the current behavior and will get this merged soon.

kdpsingh commented 6 months ago

Will take a look soon. Thank you so much for your work on this!

kdpsingh commented 4 months ago

Thanks @GlenHertz for catching this. You are right that @slice_sample(5) should throw an error instead of returning a single random row. As of #107, this now throws an error.