search

Tidwell / node-challonge

A node.js wrapper for the challonge.com API
28 stars 9 forks source link

challonge.createClient massageProperties is tautologically true #2

Closed rsxdalv closed 7 years ago

rsxdalv commented 8 years ago

Upon definition, if it evaluates to false, it is set to be true. When checked for, if it evaluates to false, you get to skip this feature. Thus, the only way to get the raw property names is to modify the property manually on the return object from create client:

(createClientReturn).client.options.massageProperties = false;

Instead of checking for false, check for undefined as undefined !== false.

Tidwell commented 7 years ago

Fixed in master, will deploy in v1.2

rsxdalv commented 7 years ago

Cool!

On Wed, Mar 15, 2017, 04:13 Aaron Tidwell notifications@github.com wrote:

Fixed in master, will deploy in v1.2

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tidwell/node-challonge/issues/2#issuecomment-286620289, or mute the thread https://github.com/notifications/unsubscribe-auth/AGcbo0dkqLbsr_xozJA-gxQH2kNea_7-ks5rl0lHgaJpZM4INiOM .