search

Tietoevry-Create / gh-actions-workshop

A lil' set of tasks to help you gain confidence and go from a beginner to intermediate creator of GitHub Actions ✨
MIT License
8 stars 0 forks source link

feat: apply strikethrough on previous tasks in navigation #5

Closed boyum closed 1 year ago

boyum commented 1 year ago

This PR adds strikethroughs to previous navigation elements in the task navigation. I think it will give some sense of completion when going through the tasks, but it might be annoying?

image
boyum commented 1 year ago

Perhaps we should remove (this task)? I'm not sure if it adds any value, even to screen reader users.

ingridaase commented 1 year ago

I like the (this task), but I feel like there are a lot of horisontal lines when there are lines both through and under the completed tasks

boyum commented 1 year ago

Are you voting "keep as is", @ingridaase? I will not remove the links (thus, the underlines), as I think it's important that it's possible to navigate to previous tasks.

ingridaase commented 1 year ago

I vote for the new feature as I like to see clearly what tasks have been completed.