TigerVNC / tigervnc

High performance, multi-platform VNC client and server
https://tigervnc.org
GNU General Public License v2.0
4.94k stars 919 forks source link

Pam option not showing for Xvnc when compiling for iOS. #1238

Closed CuteNatalie closed 3 years ago

CuteNatalie commented 3 years ago

I have created a fork of this GitHub and then removed all the limitations to make Xvnc compile for iOS. Even though I’ve changed all the options I could to make patches, I still don’t have the option for it. Is there any spots that make the pam option Unix specific?

CendioOssman commented 3 years ago

Yes, please check the top level CMakeLists.txt. We don't enable it on Apple systems as they don't use X11 and hence building the server isn't really useful. So I'm curious to know what your use case is?

CuteNatalie commented 3 years ago

And where would this file be located? I've gone through and tried to remove/change all the "if Unix" to "if Apple"

Edit: I've also forked this Github and tried to remove as much as I could find. Here is the link to my fork in case I'm missing something. https://github.com/Gymxo/tigervnc

bphinz commented 3 years ago

https://github.com/TigerVNC/tigervnc/blob/master/CMakeLists.txt

See line 267

On Tue, May 4, 2021 at 10:35 AM Gymxo @.***> wrote:

And where would this file be located? I've gone through and tried to remove/change all the "if Unix" to "if Apple"

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TigerVNC/tigervnc/issues/1238#issuecomment-831989831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB45M3OFUOT24RQICNMKONTTMAAYLANCNFSM43B2WL3Q .

CuteNatalie commented 3 years ago

https://github.com/Gymxo/tigervnc/blob/master/CMakeLists.txt#L266 I have already recompiled multiple times with that disabled.

CuteNatalie commented 3 years ago

For I've made a patch regarding that here https://github.com/ProcursusTeam/Procursus/blob/32b189929da83bb47e394d74d14a4795eeff2210/build_patch/tigervnc/0001-Update-CMakeLists.txt.patch

bphinz commented 3 years ago

I think you will probably have to drill down and look at some of the lower level CMakeLists.txt files. IE: line 78 in https://github.com/TigerVNC/tigervnc/blob/master/common/rfb/CMakeLists.txt

On Tue, May 4, 2021 at 10:49 AM Gymxo @.***> wrote:

For I've made a patch regarding that here https://github.com/ProcursusTeam/Procursus/blob/32b189929da83bb47e394d74d14a4795eeff2210/build_patch/tigervnc/0001-Update-CMakeLists.txt.patch

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TigerVNC/tigervnc/issues/1238#issuecomment-832000752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB45M3NJ3ATZD4C7XOKS5BDTMACNHANCNFSM43B2WL3Q .