search

TigerVNC / tigervnc

High performance, multi-platform VNC client and server
https://tigervnc.org
GNU General Public License v2.0
4.85k stars 907 forks source link

x0vncserver HDR (10-bit) support #1733

Open nameiwillforget opened 4 months ago

nameiwillforget commented 4 months ago

Is your feature request related to a problem? Please describe. While attempting to use my laptop to connect to my desktop session using x0vncserver, I found that I couldn't do it as long as the color depth of the desktop was at 10 bit (that of my laptop is at 8).

Describe the solution you'd like An option to display the current session at a different color depth, similar to -geometry for resolutions.

CendioOssman commented 4 months ago

I don't know if anyone has ever tested things on HDR system, so I'm not surprised there are issues.

Exactly what happens when you try to use x0vncserver?

nameiwillforget commented 4 months ago

"Pierre Ossman (ThinLinc team)" @.***> writes:

I don't know if anyone has ever tested things on HDR system, so I'm not surprised there are issues.

Exactly what happens when you try to use x0vncserver?

On the server side:

***@***.*** tmp]$ x0vncserver -geometry 1920x1080 -rfbauth ~/.vnc/passwd 

Fri Mar  1 19:13:18 2024
 Geometry:    Desktop geometry is set to 1920x1080+0+0
 XDesktop:    Using evdev codemap
 XDesktop:    
 XDesktop:    XTest extension present - version 2.2
 XDesktop:    RANDR extension not present
 XDesktop:    Will not be able to handle session resize
 Main:        Listening for VNC connections on all interface(s), port 5900

Fri Mar  1 19:13:22 2024
 Connections: accepted: 10.0.0.13::41268
 SConnection: Client needs protocol version 3.8
 SConnection: Client requests security type VeNCrypt(19)
 SVeNCrypt:   Client requests security type TLSVnc (258)
 XDesktop:    Enabling 8 buttons of X pointer device
 VNCSConnST:  closing 10.0.0.13::41268: invalid pixel format
 EncodeManager: Framebuffer updates: 0
 EncodeManager:   Total: 0 rects, 0 pixels
 EncodeManager:          0 B (1:-nan ratio)
 Connections: closed: 10.0.0.13::41268

On the client side it just says that the connection was closed.

CendioOssman commented 3 months ago

Thanks. Unfortunately, this is expected. I even found a comment in the code:

https://github.com/TigerVNC/tigervnc/blob/e9d78517c90f393a5f5c420d6543b958d2b31032/common/rfb/PixelFormat.cxx#L685-L688

It might be possible to support your use case, but unfortunately, it is rare enough that it might take some time before anyone has a look at it.