search

TigerVNC / tigervnc

High performance, multi-platform VNC client and server
https://tigervnc.org
GNU General Public License v2.0
5.24k stars 954 forks source link

cant build tigervnc-1.14.0-1.el9.src.rpm: ../xserver211.patch: No such file or directory #1845

Closed korn3r closed 1 month ago

korn3r commented 1 month ago

Describe the bug there is no xserver211.patch inside tigervnc-1.14.0-1.el9.src.rpm or tigervnc-1.13.90-1.el9.src.rpm from sourceforge

To Reproduce Steps to reproduce the behavior: 1.0. probably need to compile xorg-server version 21.1 and install it first 1.1. download tigervnc-1.14.0-1.el9.src.rpm

  1. rpm2cpio tigervnc-1.14.0-1.el9.src.rpm | cpio -idmv
  2. rpmbuild -ba tigervnc.spec

Expected behavior i would expect it to build

Screenshots If applicable, add screenshots to help explain your problem.

Client (please complete the following information):

Server (please complete the following information):

Additional context Does it want this patch? Its xserver21.patch, not xserver211.patch, but it might be it

also this might be due to me compiling some fresh xorg for my distro

[u@192 SOURCES]$ dnf list installed | grep xorg-x11-server
xorg-x11-server-Xorg.x86_64                    21.1.13-5.el9                       @local2
xorg-x11-server-Xvfb.x86_64                    21.1.13-5.el9                       @local2
xorg-x11-server-common.x86_64                  21.1.13-5.el9                       @local2
xorg-x11-server-devel.x86_64                   21.1.13-5.el9                       @local2
xorg-x11-server-source.noarch                  21.1.13-5.el9                       @local2
xorg-x11-server-utils.x86_64                   7.7-44.el9                          @AppStream
CendioOssman commented 1 month ago

Xorg 21.1.13 is not the expected version of Xorg for Rocky Linux 9. I assume it builds well if you use the Xorg packages provided by the distribution?

korn3r commented 1 month ago

Xorg 21.1.13 is not the expected version of Xorg for Rocky Linux 9. I assume it builds well if you use the Xorg packages provided by the distribution?

probably. i didnt try. what i did try is to replace xserver_patch="../xserver$(rpm -q --qf '%%{VERSION}' xorg-x11-server-source | awk -F. '{ print $1 $2 }').patch" with xserver_patch="../xserver$(rpm -q --qf '%%{VERSION}' xorg-x11-server-source | awk -F. '{ print $1 $2 }' | cut -c1-2).patch" to make it return only 2 digits instead of 3. to fit patch name. and it compiled. that one probably wont work on old xserver, because other patch (for older xserver) has 3 digits in version

how would it even work on 21 branch if it prints major+minor version, but patch name itself has only major? old xorg-server is 1.20, so getting major+minor version fits patchname - xserver120.patch but new xserver has major version of 21, and no matter what minor version is, it wont fit patch name - xserver21.patch

CendioOssman commented 1 month ago

Xorg changed their numbering scheme and released 21 instead of 1.21. So we'll need to update that .spec file once Red Hat switches to that new version. But for now, it matches what's expected in RHEL 9. If you want to build with a different Xorg, you'll need to modify things as you've already done.