search

TigerVNC / tigervnc

High performance, multi-platform VNC client and server
https://tigervnc.org
GNU General Public License v2.0
5.11k stars 936 forks source link

Cannot build vncviewer without NLS #949

Open Peter2121 opened 4 years ago

Peter2121 commented 4 years ago

I'm trying to build tigervnc from Git on Mac OS X 10.13.6. It builds correctly with the default options, but when I try to build without NLS - it's failed.

CMAKE command: cmake -G "Unix Makefiles" -DENABLE_NLS=false ..

Trying to build I get many errors like this:

/Users/peter/Programming/tigervnc/vncviewer/Viewport.cxx:1240:30: error: use of undeclared identifier 'LC_MESSAGES'
  fltk_menu_add(contextMenu, p_("ContextMenu|", "&Options..."),
--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/87765950-cannot-build-vncviewer-without-nls?utm_campaign=plugin&utm_content=tracker%2F3557444&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F3557444&utm_medium=issues&utm_source=github).
CendioOssman commented 4 years ago

I can reproduce the issue here as well. It seems gettext's standard header assumes that the locale defines are present even if gettext is missing.

Will need to do some form of workaround.