Tigereye504 / chestcavity

Side effects may include shortness of breath, inhibited healing, inability to fight off infection, vulnerability to physical harm, weakness, loss of nutrition, difficulty walking or running, and sacrifice to Aztec gods .
26 stars 14 forks source link

Shearing sheep crashes on 1.19.2 #98

Closed macmv closed 1 year ago

macmv commented 1 year ago

Shearing sheeps causes a crash on 1.19.2, on my dedicated server. I'm running version 2.16.4.

Stack trace is below.

java.lang.NoClassDefFoundError: net/minecraft/class_1132
        at net.minecraft.world.entity.animal.Sheep.handler$bpf000$chestcavity$chestCavitySheared(Sheep.java:1822)
        at net.minecraft.world.entity.animal.Sheep.shear(Sheep.java)
        at net.minecraft.world.entity.animal.Sheep.mobInteract(Sheep.java:236)
        at net.minecraft.world.entity.Mob.interact(Mob.java:1135)
        at net.minecraft.world.entity.player.Player.interactOn(Player.java:1097)
        at net.minecraft.server.network.ServerGamePacketListenerImpl$1.performInteraction(ServerGamePacketListenerImpl.java:1671)
        at net.minecraft.server.network.ServerGamePacketListenerImpl$1.onInteraction(ServerGamePacketListenerImpl.java:1682)
        at net.minecraft.network.protocol.game.ServerboundInteractPacket$InteractionAction.dispatch(ServerboundInteractPacket.java:116)
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.dispatch(ServerboundInteractPacket.java:66)
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleInteract(ServerGamePacketListenerImpl.java:1668)
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:53)
        at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:13)
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:22)
        at net.minecraft.server.TickTask.run(TickTask.java:18)
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:157)
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23)
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:776)
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:159)
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:131)
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:758)
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:752)
        at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:116)
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:736)
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:669)
        at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:257)
        at java.base@17.0.7/java.lang.Thread.run(Thread.java:833)

Note that net/minecraft/class_1132 is IntegratedServer.

I believe this bit is the problem: https://github.com/Tigereye504/chestcavity/blob/master/src/main/java/net/tigereye/chestcavity/mixin/MixinLivingEntity.java#L321-L323. OrganUtil then imports IntegratedServer, and doesn't appear to use it? So I'm confused why this is causing an exeption, but thats where I am with debugging so far.

I'll write a fix in the next couple days if I have some time. If someone's reading this and wants to have a go at fixing it, be my guest :)