search

Tigge / openant

ANT and ANT-FS Python Library
MIT License
174 stars 80 forks source link

Modified the udev to call the non-sudo python version #17

Closed glemaitre closed 7 years ago

glemaitre commented 8 years ago

It is what I mean in the PR #16

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 51.621% when pulling fbf01faf6ea6f0092d1bcd7e2bdca0d06ec277c5 on glemaitre:setup_conda_fix into ba4c276fec0be36ab27e4b727a29836d368b59a6 on Tigge:master.

Tigge commented 7 years ago

It is a bit better than the previous solution but I'm still not convinced, could you provide a bit more background as to what is the problem and why. If you are still interested please reopen as you see fit, thank you.

glemaitre commented 7 years ago

This is long time a ago but if I recall well, the issue was the following. The current setup.py script request to be executed as super-user (su). However, doing so, the python distribution used will be always the system one even with anaconda environment (or conda, virtualenv, or pip I supposed).

After some thoughts the current solution and this PR are wrong. This PR will not work if the user rely on the python system as in Ubuntu. You will need the sudo privileges to install it. However, the current solution is not working for the previous user-based environment mentioned.

So what seems to be the best is to split both udev and python package install. The udevadm and cp can be placed in a Makefile or a separate script. Therefore, the python setup file will only handle only python package related stuff.