search

Tigge / openant

ANT and ANT-FS Python Library
MIT License
182 stars 85 forks source link

UploadDataCommand._parse_args() return is truncated #21

Closed Echelon9 closed 7 years ago

Echelon9 commented 7 years ago

pylint warning identifies a potential problem with UploadDataCommand._parse_args()

    @classmethod
    def _parse_args(cls, data):
        return struct.unpack("<BBHI", data[0:8])
        + (data[8:-8],) + struct.unpack("<6xH", data[-8:])
        ^ # W:306, 8: Expression "(+(data[8:-8], )) + (struct.unpack('<6xH', data[-8:]))" is assigned to nothing (expression-not-assigned)

i.e. because the plus symbol is not on the prior line, this function only returns the data up to struct.unpack("<BBHI", data[0:8]) and nothing further.