search

Tigge / openant

ANT and ANT-FS Python Library
MIT License
174 stars 80 forks source link

adding antplus, first working version #53

Closed stefaandesmet2003 closed 1 year ago

stefaandesmet2003 commented 3 years ago

Hi, offering here a look at my work in progress on adding support for ant+ in your repo. I added details in the readme.md about the changes I made and why. main reason for the changes is support for multiple open channels (for instance FE-C + cadence sensor, or HRM), which didn't work well with your code base. Unfortunately I cannot test if my changes break functionality on ant-fs, I don't have a suitable device. I don't expect a break, only doubt is the time.sleep(0.1) you had after every received broadcast, and which solved a lot of my problems after I removed this line. forget about the changes in travis.yaml, I removed python<3.6, because I had f-strings in the logging code, and only realized the consequences after setting up travis & coveralls this morning. cheers, Stefaan

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-14.9%) to 40.877% when pulling 6dfa2ae7e90e6d537168c7a38cf30745dbfc2f2c on stefaandesmet2003:master into 3b8dfc9f33e933f47c858a12273f65eeb76220f6 on Tigge:master.

stefaandesmet2003 commented 3 years ago

I've started to look at the initial ant.base/ease packages, and it mostly looks good. Some extra unnecessary comments - but this is a WIP I guess. Having a bit of a struggle with the Dutch as well . Will continue to look at the new antplus stuff!

your review is much appreciated!

purpl3F0x commented 1 year ago

Is this active ? Any need for some help ?

tuna-f1sh commented 1 year ago

Thanks for the work on this but closing as ANT+ device support is added with #76 and this is now out of date.

purpl3F0x commented 1 year ago

Sorry, but I think @stefaandesmet2003 version seems much more cohesive, complete and scalable, imo.

tuna-f1sh commented 1 year ago

Fair enough and no need to be sorry, I don't take it personally! Pity you didn't see my PR to comment then, but open to PRs to improve on what I've done.