Tigge / openant

ANT and ANT-FS Python Library
MIT License
174 stars 80 forks source link

Only run install_udev_rules on linux hosts #70

Closed tuna-f1sh closed 2 years ago

tuna-f1sh commented 2 years ago

The is_windows() check isn't broad enough; macOS hosts also do not use udev and will raise an exception at this step.

I'd personally remove the exception for the general CustomInstall. Even on Linux hosts, if one is installing in a virtualenv with this as a module inside another project's requirements, it's not good to have to run all project dependencies as an elevated user. It would be better to mention in the README regarding udev rules.