search

TigraTT-Driver / shinretro

A flexible and tweakable theme for Pegasus Frontend.
GNU General Public License v3.0
22 stars 19 forks source link

Fix #64 #70

Closed TigraTT-Driver closed 2 years ago

TigraTT-Driver commented 2 years ago

show collection name in description of game view

TigraTT-Driver commented 2 years ago

@msheehan79 there we have both worked on the same problem :) I found your version better, however, is not yet displayed with me the collection name. only the "for". I have now both merged together so that also with your version the info is displayed correctly on my side. can you check your custom collection implementation whether everything still fits there. unfortunately, I have not yet come to implement this on my setup.

msheehan79 commented 2 years ago

@TigraTT-Driver yes I wasn't planning on submitting a PR as I haven't had much time for working on this lately, but I found myself with a few minutes to add this fix today so figured I'd send it over. I tested your updated branch and works fine for custom collections so from my side everything looks good.

msheehan79 commented 2 years ago

@TigraTT-Driver Actually upon further review - I've had another thought as to why you did not see anything for the platform name. I had added a custom metadata field called 'system' on the games metadata where I stored whatever system every game is from, and I draw from this metadata to populate the "systemName" field on the view.

Since you would not have this extra metadata set, that would explain why it came up as blank on your test. Your workaround to pull the first collection name from the game is a reasonable solution. It does make the assumption that the first collection any given game is in is the "System" collection but I think that is probably going to be the case more often than not.