Tihauan / jsgauge

Automatically exported from code.google.com/p/jsgauge
0 stars 0 forks source link

draw function param #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The draw function in jQuery should be:
...
draw : function( ) {  
        return this.each(function(){
            var gauge = $(this).data('gauge');
            if (gauge != null) {        
                gauge.draw( value  ); //<---- should not take any param
            }
        });
    }
...

so line 97 may be changed to:  gauge.draw(   ) and becomes:
http://code.google.com/p/jsgauge/source/browse/tags/jsgauge-0.4.1/build/jquery.g
auge.js#97

draw : function( ) {  
        return this.each(function(){
            var gauge = $(this).data('gauge');
            if (gauge != null) {        
                gauge.draw(    ); //<---- should not take any param
            }
        });
    }

Original issue reported on code.google.com by mchinnap...@gmail.com on 27 Dec 2011 at 7:00

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r63.

Original comment by dragos.tihauan on 1 Jan 2012 at 8:07

GoogleCodeExporter commented 9 years ago
Thanks for the fix.

Original comment by mchinnap...@gmail.com on 1 Jan 2012 at 8:37

GoogleCodeExporter commented 9 years ago
Dear dragos.tihauan,

If you can provide me commit access, I can contribute in bug fixes and new
features.

With Best Regards,
Mohan Chinnappan

Original comment by mchinnap...@gmail.com on 1 Jan 2012 at 8:40