search

Tiiffi / mcrcon

Rcon client for Minecraft
https://github.com/Tiiffi/mcrcon/
zlib License
834 stars 116 forks source link

use GNU readline for auto completion #68

Closed BruceKangCN closed 2 years ago

Hagb commented 3 years ago

To use GNU readline licensed under GPL, maybe mcrcon should also be licensed under GPL too.

Tiiffi commented 3 years ago

Hi,

I think this is very good addition but the only problem I have with getline is that it adds dependency which may cause problems on different platforms. I am also trying to keep mcrcon simple and easy to compile with reasonably minimal dependencies.

I think the best solution is to make the getline support optional. Perhaps using makefile option like this: make getline=1

@Hagb

To use GNU readline licensed under GPL, maybe mcrcon should also be licensed under GPL too.

As fas as I know Zlib license is compatible with GPL so there shouldn't be any problem with that.

Hagb commented 3 years ago

@Tiiffi

As fas as I know Zlib license is compatible with GPL so there shouldn't be any problem with that.

Sorry for my misunderstanding about GPL-compatibility. You are right. https://www.gnu.org/licenses/gpl-faq.html#IfLibraryIsGPL