Tijani-Dia / dj-tracker

A Django app that tracks your queries to help optimize them. Demo: https://dj-tracker-bakerydemo.fly.dev/dj-tracker/
https://tijani-dia.github.io/dj-tracker/
BSD 3-Clause "New" or "Revised" License
79 stars 3 forks source link

LOGIN and IGNORE_CONFLICT params #27

Closed Natgho closed 11 months ago

codecov-commenter commented 11 months ago

Codecov Report

Merging #27 (73c8cec) into main (b600d7d) will decrease coverage by 0.40%. The diff coverage is 42.85%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   86.14%   85.75%   -0.40%     
==========================================
  Files          19       20       +1     
  Lines        1537     1551      +14     
  Branches      228      232       +4     
==========================================
+ Hits         1324     1330       +6     
- Misses        183      190       +7     
- Partials       30       31       +1     
Files Coverage Δ
src/dj_tracker/constants.py 100.00% <ø> (ø)
src/dj_tracker/promise.py 95.91% <100.00%> (+0.01%) :arrow_up:
src/dj_tracker/urls.py 73.33% <60.00%> (-6.67%) :arrow_down:
src/dj_tracker/urlpatterns.py 25.00% <25.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Tijani-Dia commented 11 months ago

@Natgho Thanks for opening these.

I'd suggest opening separate PRs for each feature to make things easier to review.

I'm unsure about the ignore_conflicts addition. As I said, I've been working on making it work with multiple processes but I'm taking a whole different approach. Moreover, we'll need to ensure that the ignore_conflicts actually works.

Natgho commented 11 months ago

Hi,

Yes you are right, I only put the login feature in this PR. I leave the other issue to you, I can help the code if you open it as a PR.