TikhonJelvis / RL-book

523 stars 328 forks source link

chapter numbering in pdf and rl folder #209

Open Peymankor opened 2 years ago

Peymankor commented 2 years ago

Hi,

When you read the book pdf, say I am reading Chapter 3. "3. Dynamic Programming Algorithms", the python code ("clearance_pricing_mdp.py") for the chapter has been located in chapter4 of the rl folder. I do not think that is a big issue (you read Chapter 3 and codes are in chapter4 folder), but if you can come up with a quick-fix, it can lead to further consistency of book pdf with codes.

One suggestion maybe is to number the chapters in rl folder from 0, instead of 1 (like book folder), then I feel the pdf book will match with the codes in rl folder. But I am afraid that may break some internal structure you already have :)

coverdrive commented 2 years ago

Thanks for pointing this out. It’s a concern Tikhon and I share, and we plan to fix it.

On Mon, Jan 17, 2022 at 8:51 AM Peyman Kor @.***> wrote:

Hi,

When you read the book pdf, say I am reading Chapter 3. "3. Dynamic Programming Algorithms", the python code ("clearance_pricing_mdp.py") for the chapter has been located in chapter4 of the rl folder. I do not think that is a big issue (you read Chapter 3 and codes are in chapter4 folder), but if you can come up with a quick-fix, it can lead to further consistency of book pdf with codes.

One suggestion maybe is to number the chapters in rl folder from 0, instead of 1 (like book folder), then I feel the pdf book will match with the codes in rl folder. But I am afraid that may break some internal structure you already have :)

— Reply to this email directly, view it on GitHub https://github.com/TikhonJelvis/RL-book/issues/209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANQAK4ZJG6EIHFNPF5WOGTUWRCIXANCNFSM5MFE4VOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

--