TilCreator / Tapas-Comic-Downloader

This is a downloader to download whole comics from https://tapas.io/. (Not official!)
MIT License
70 stars 15 forks source link

Index Error #14

Closed ONSKJ closed 4 years ago

ONSKJ commented 4 years ago

Hello!

It's me again! I don't know if this is only a problem on my type of computer (Windows 8) but when tried using your new code, I received an error for every single input I used. Before the code worked on any comic, just not the ones where I encountered unicode support errors. But now, I get an Index Error before the code can even fully execute. This is the error I get:

Capture

TilCreator commented 4 years ago

Tapas seams to have changed the site, so my current method doesn't work anymore. Best thing to do would be to monitor the network traffic of the app and use the API the app uses. But I sadly will not have time for the next months.

So if someone can find a way to make the old method work again, the script will be fixed quickly, but else it sadly will be a few months.

See the extra section in the README.md: The _data variable is not used anymore, so I can't use it like usual for getting all the page ids.

TilCreator commented 4 years ago

Hmm, I can find direct links to the next page on ever page, maybe that could be used, will have a look in the next few days.

TilCreator commented 4 years ago

Notes:

l1m3r commented 4 years ago

Hmm, I can find direct links to the next page on ever page, maybe that could be used, will have a look in the next few days.

sorry for this little shameless self plug, but I just updated my tapas.io downloader script to work with the new website.

feel free to copy the new regexes.

TilCreator commented 4 years ago

Have you found a new list of page ids or is it just he next links?

Also thx for the offer, but I'm not parsing xml with regex (again) ^^

l1m3r commented 4 years ago

I never worked with a/the list of page IDs -> The script always only use the next page links. I didn't even modify your old script to work with the name of the comic - it still needs a episode number to start/work with. :-/

TilCreator commented 4 years ago

I think my rewrite was worth it, still meh, that it broke.

I will hopefully have time to fix the tomorrow.

l1m3r commented 4 years ago

well just today i wanted to use my script again and it didn't work anymore. Guess what my first step was: Hmmm, let's see if TilCreators new script still works or was updated to work recently. ;-)

If your new one had worked now I would've had the choice between A) updating mine and B) installing python on my Windows to run yours -> might have chosen B and abandoned mine...

TilCreator commented 4 years ago

Fixed in: 4a524501fbccd8a3f102282b23cdfa9b1cb62dae