search

TilCreator / Tapas-Comic-Downloader

This is a downloader to download whole comics from https://tapas.io/. (Not official!)
MIT License
67 stars 16 forks source link

Fix cross-platform and some problems. #4

Closed Tetragramm closed 5 years ago

Tetragramm commented 5 years ago

Should be able to run on Windows with the appropriate pip command for your python version (pip or pip3). At least works on my machine. Also cleaned up a good number of problems I found.

TilCreator commented 5 years ago

63523f2223a3d177df411dc625467826aa6b656c : I see the problem, but just removing it seem like the wrong action. If it is the import that fails, just move the import into the getTerminalSize function and catch it. ( the function already has a fallback, it just needs improvements ) ( Can't test what fails right now, because i have no Win maschine or vm nearby, only Linux. )

TilCreator commented 5 years ago

35fb447596ede246f8c6aecbddb70e5f56ebeb6c : Good change, but please use https://www.python.org/dev/peps/pep-0008/#code-lay-out in line 90 and wrap the char removing inside a if command arg, because most of the filesystem that I use have no problem with those chars. Example:

parser.add_argument('-c', '--no-special-chars', action="store_true", help='Removes all kinds of special chars from dir and filenames. ( Use if your filesystem does not support special chars )')
...
if args.no_special_chars:
    ...
TilCreator commented 5 years ago

2250fd07b035bb7f77991c7860b51d433d0ee40c : If it fails for you, it is because it checks for a dirname that can not exist on your filesystem ( this is a guess ), so please revert this and do something like in 35fb447596ede246f8c6aecbddb70e5f56ebeb6c ( with those improvements https://github.com/TilCreator/Tapas-Comic-Downloader/pull/4#issuecomment-431251941 ) .

TilCreator commented 5 years ago

Should be able to run on Windows with the appropriate pip command for your python version (pip or pip3).

The script is forced to run with Python3 via the shebang.

But thx for testing on Windows, I have never done that.