Tilakkumar / cleartk

Automatically exported from code.google.com/p/cleartk
0 stars 0 forks source link

rename InstanceConsumer.consumeAll to consumeSequence #66

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
    I wonder if InstanceConsumer.consumeAll shouldn't be named
    consumeSequence.  ClassifierAnnotator.consumeAll simply delegates to its
    classifiers classifySequence method.  I ask because I am writing up a
    description of what FeatureOutcomeExtractors are for.  I need a working
    definition of what it means to be performing a sequential tagging task -
    which for me is when your annotation handler calls consumeAll.  It seems
    strange not to call this method consumeSequence.  Was this a deliberate
    decision - or an oversight?

Agree. I don't remember having a good reason for going with consumeAll --
other than we had been naming things all day and were probably getting
worse and worse at it :)

consumeSequence makes more sense.

Original issue reported on code.google.com by pvogren@gmail.com on 6 Mar 2009 at 4:58

GoogleCodeExporter commented 8 years ago

Original comment by pvogren@gmail.com on 6 Apr 2009 at 11:21

GoogleCodeExporter commented 8 years ago

Original comment by pvogren@gmail.com on 6 Apr 2009 at 11:21