search

Tilakkumar / cleartk

Automatically exported from code.google.com/p/cleartk
0 stars 0 forks source link

split Classifier into Classifier and SequentialClassifier #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Philipp and I were discussing the possibility of splitting up the
Classifier interface into two interfaces - one for non-sequential
classifiers and another for sequential classifiers.  I think this makes a
lot of sense and wouldn't be that hard to do.  This split will probably
also affect instance consumers, data writers, and classifier annotators. 
Even still, I think it is probably worth doing.

Original issue reported on code.google.com by pvogren@gmail.com on 6 Apr 2009 at 6:59

GoogleCodeExporter commented 9 years ago 
I agree. We're already basically adding two paths everywhere for the two types 
of
classifiers anyway. It'll also make it more obvious what the point of your
NonSequential-to-Sequential adapter is.

Original comment by steven.b...@gmail.com on 6 Apr 2009 at 7:13

GoogleCodeExporter commented 9 years ago 
I'm going to consider this issue closed. we changed all the relevant 
interfaces, fix
the implementations, and got most of the unit tests running again. There is now 
a
ClassifierAnnotator class and a SequentialClassifierAnnotator class - this is 
true
for InstanceConsumer and DataWriterAnnotator, etc.

Original comment by pvogren@gmail.com on 5 May 2009 at 2:53