Tilakkumar / cleartk

Automatically exported from code.google.com/p/cleartk
0 stars 0 forks source link

make classifier constructors take InputStream instead of JarFile #93

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
right now the constructors for the classifiers require a jar file. This is
not ideal for the viterbi classifier which has a classifier model inside
its jar file that it needs to use to instantiate the delegated classifier.
This means that the viterbi classifier has to extract the jar file before
it can instantiate the delegated classifier.  It would be better if we
re-factored the constructors to take an input stream such as the
JarInputStream.  Fixing this will require changes to ClassifierFactory and
probably ClassifierManifest.

Original issue reported on code.google.com by pvogren@gmail.com on 30 Apr 2009 at 1:59

GoogleCodeExporter commented 8 years ago
ViterbiClassifier wouldn't have to write a temp file if it took an InputStream.
However, this wouldn't solve the LIBSVMClassifier problem - it still needs to 
write a
temp file because LIBSVM can only read from an actual path. So as long as 
another
classifier is having to write temp files, I don't think there's a good reason to
change this.

Original comment by steven.b...@gmail.com on 27 Oct 2009 at 4:41

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r2384.

Original comment by steven.b...@gmail.com on 1 Feb 2011 at 11:19