Add tests and fix for NetCDF4ConverterEngine - Githubissues

TileDB-Inc / TileDB-CF-Py

TileDB interface with awareness of the CF metadata conventions

https://tiledb-inc.github.io/TileDB-CF-Py/

MIT License

19 stars 3 forks source link

Add tests and fix for NetCDF4ConverterEngine #17

Closed jp-dark closed 3 years ago

jp-dark commented 3 years ago

Breaking Behavior:

Makes NetCDF4ConverterEngine methods add_ncvar_to_attr and add_ncdim_to_dim private.

Bug fixes:

Fixes auto-detection of tile size from variables with matching chunksizes.

Refactor:

Removes code for adding NetCDF as a data dimension (it will always be an index dimension).

Tests:

Adds test cases for auto-tiling NetCDF variables with chunks.
Adds test for adding array to NetCDF4EngineConverter where name already exists.
Marks a couple exceptions that shouldn't be reached with no cover for pytest-cov.