TileDB-Inc / TileDB-CF-Py

TileDB interface with awareness of the CF metadata conventions
https://tiledb-inc.github.io/TileDB-CF-Py/
MIT License
19 stars 3 forks source link

Add dataspace creator and NetCDF backend converter engine #6

Closed jp-dark closed 3 years ago

jp-dark commented 3 years ago

This is a large pull request that adds the features needed to convert a NetCDF group to a TileDB group. It mostly consists of new code with few changes to the exists core library (moved from tiledb/cf/__init__.py to tiledb/cf/core.py).

Summary:

normanb commented 3 years ago

@jp-dark this looks good, I have installed and run the code and also gone over the changes. A couple of comments;

  1. A chore, but can you check the year for the copyright headers (2020 or 2021)?
  2. Can you add a CLI interface to the from_netcdf method?