Always link to tiledb dynamically.

TileDB-Inc / TileDB-Java

Java JNI interface to the TileDB storage engine

MIT License

26 stars 5 forks source link

Always link to tiledb dynamically. #314

Closed teo-tsirpanis closed 1 year ago

teo-tsirpanis commented 1 year ago

SC-34269

Since the macOS and Linux release artifacts already contain only dynamic libraries, this should have effect only on Windows (where we bundle tiledb.dll in the maven package either way).

Let's see what CI thinks.

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #34269: Reconsider having tiledbjni statically link to tiledb on Windows..

DimitrisStaratzis commented 1 year ago

Thank you @teo-tsirpanis. Looks LGTM. I will do some testing tomorrow and approve.

DimitrisStaratzis commented 1 year ago

Playing with CI to test releases. Will revert my changes