search

TileDB-Inc / TileDB-Py

Python interface to the TileDB storage engine
MIT License
190 stars 33 forks source link

Add extra argument to `Group::add_member` #2093

Closed kounelisagis closed 3 weeks ago

kounelisagis commented 3 weeks ago

Context: https://github.com/TileDB-Inc/centralized-tiledb-nightlies/issues/24#issuecomment-2422556663

Should fix the related error in https://github.com/TileDB-Inc/centralized-tiledb-nightlies/issues/24 cc @jdblischak

[sc-58033]

teo-tsirpanis commented 3 weeks ago

Can you run nightlies against Core dev?

jdblischak commented 3 weeks ago

Testing this branch agis/add-new-argument-for-Group--add_member against dev libtiledb in https://github.com/TileDB-Inc/centralized-tiledb-nightlies/actions/runs/11407797939

jdblischak commented 3 weeks ago

Build passed but two test failures. Regardless this means that this PR fixes the broken build against dev libtiledb

kounelisagis commented 3 weeks ago

I agree, @jdblischak. However, I don't understand why these two tests are failing. I merged from the dev branch, so these issues should have been fixed by now.

kounelisagis commented 3 weeks ago

I guess you have to re-run the workflow from the beginning after I merged. If this is the case, everything is ok.

jdblischak commented 3 weeks ago

However, I don't understand why these two tests are failing. I merged from the dev branch, so these issues should have been fixed by now.

The nightly pipeline checked out b0aaccf1f1cade27b6082886ddec72b0adbe1285 (log), so it should have had the latest changes from dev from your merge.

I also don't know why the 2 tests continue to fail. But I don't believe they are related to this PR. Thus I think we should merge this PR, and then we can continue to troubleshoot the failing tests if necessary.

jdblischak commented 3 weeks ago

The nightly pipeline checked out b0aaccf1f1cade27b6082886ddec72b0adbe1285 (log), so it should have had the latest changes from dev from your merge.

Oops. I didn't realize that you had already restarted it. You are correct that on the first attempt it didn't have the latest changes from dev. FWIW the number of failing tests reduced from 3 to 2 after merging dev.

https://github.com/TileDB-Inc/centralized-tiledb-nightlies/actions/runs/11407797939/attempts/1