search

TileDB-Inc / TileDB-VCF

Efficient variant-call data storage and retrieval library using the TileDB storage library.
https://tiledb-inc.github.io/TileDB-VCF/
MIT License
83 stars 13 forks source link

Load VCF headers when required for in-memory exports #619

Closed gspowley closed 8 months ago

gspowley commented 8 months ago

PR #479 stopped loading the VCF headers for all in-memory exports and relied on the "first" VCF header to decode FILTER, INFO, and FORMAT fields.

PR #479 works fine when all samples have the same VCF header. However, it causes an issue when samples have different FILTER lists because the filter_id (stored as an int) needs the original VCF header when decoding back to the FILTER string.

This PR reverts the change in #479.

shortcut-integration[bot] commented 8 months ago

This pull request has been linked to Shortcut Story #36955: Load VCF headers when required for in-memory exports.