search

TileDB-Inc / TileDB-VCF

Efficient variant-call data storage and retrieval library using the TileDB storage library.
https://tiledb-inc.github.io/TileDB-VCF/
MIT License
83 stars 13 forks source link

Wrong type hint for dataset python api #650

Closed lowmann15 closed 4 months ago

lowmann15 commented 5 months ago

Issue Description

The python api for the dataset class contains a mode attribute which is type hinted as a boolean value, but will be handled as a string in the code.

Expected Behavior

The correct type hint should be str

Actual Behavior

The current type hint is bool

Environment

tiledbvcf-py version 0.27.0

awenocur commented 5 months ago

Thank you for bringing this to our attention. We'll add a fix to the next release.

gspowley commented 4 months ago

Resolved in #658.