TileDB-Inc / TileDB-VCF

Efficient variant-call data storage and retrieval library using the TileDB storage library.
https://tiledb-inc.github.io/TileDB-VCF/
MIT License
83 stars 13 forks source link

Move to c++20 #682

Closed awenocur closed 3 months ago

jdblischak commented 3 months ago

The Docker builds are both failing due to the new #include <span>

##[error]#11 37.58 /tmp/TileDB-VCF/libtiledbvcf/src/stats/array_buffers.h:38:10: fatal error: span: No such file or directory
##[error]#11 37.58    38 | #include <span>
##[error]#11 37.58       |          ^~~~~~
##[error]#11 37.59 compilation terminated.
ihnorton commented 3 months ago

Merging so we get a nightly run tonight.

jdblischak commented 3 months ago

Merging so we get a nightly run tonight.

FYI the nightly job passed https://github.com/TileDB-Inc/TileDB-VCF/actions/runs/8406431334