search

TileDB-Inc / centralized-tiledb-nightlies

Centralized nightly builds of TileDB stack
2 stars 1 forks source link

The centralized nightlies job failed on Monday (2024-09-09) #22

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

The centralized nightlies job failed on Monday (2024-09-09) in run 10784593621

jdblischak commented 1 month ago

One TileDB-Py test failed last night. I restarted the TileDB-Py build

tiledb/tests/test_enumeration.py:95: AssertionError
=========================== short test summary info ============================
FAILED tiledb/tests/test_enumeration.py::EnumerationTest::test_array_schema_enumeration - AssertionError
== 1 failed, 970 passed, 5 skipped, 8 xfailed, 1 xpassed in 104.67s (0:01:44) ==
github-actions[bot] commented 1 month ago

The centralized nightlies job failed on Tuesday (2024-09-10) in run 10784593621

jdblischak commented 1 month ago

The same TileDB-Py test failed again, this time with a more verbose error message:

tiledb/tests/test_enumeration.py:95: AssertionError
=========================== short test summary info ============================
FAILED tiledb/tests/test_enumeration.py::EnumerationTest::test_array_schema_enumeration - assert " No enumeration named 'enmr3'" in "Array: Unable to get enumeration; Enumeration 'enmr3' does not exist."
 +  where "Array: Unable to get enumeration; Enumeration 'enmr3' does not exist." = str(TileDBError("Array: Unable to get enumeration; Enumeration 'enmr3' does not exist."))
 +    where TileDBError("Array: Unable to get enumeration; Enumeration 'enmr3' does not exist.") = <ExceptionInfo TileDBError("Array: Unable to get enumeration; Enumeration 'enmr3' does not exist.") tblen=4>.value
== 1 failed, 970 passed, 5 skipped, 8 xfailed, 1 xpassed in 109.12s (0:01:49) ==
jdblischak commented 1 month ago

It looks like this error will be fixed by https://github.com/TileDB-Inc/TileDB-Py/pull/1975/commits/814b25bde13a1a9f43649ce669b8b6ab2ec6d783 in the pending PR https://github.com/TileDB-Inc/TileDB-Py/pull/1975. @kounelisagis could you please confirm that your PR will fix this failing test? Also, what is the timeline for merging your PR into dev? If it isn't going to be merged imminently, could we cherry-pick https://github.com/TileDB-Inc/TileDB-Py/pull/1975/commits/814b25bde13a1a9f43649ce669b8b6ab2ec6d783 into its own PR?

kounelisagis commented 1 month ago

@jdblischak yes, https://github.com/TileDB-Inc/TileDB-Py/pull/1975 resolves the failing test.

However, we cannot merge this fix (cherry-picking a new PR), as the TileDB-Py dev branch always targets stable releases, with the current one being 2.25.0. The fix should remain in its current branch since it is the only one that builds against 2.26.0, where this change will be introduced, as per https://github.com/TileDB-Inc/TileDB/pull/5293.

jdblischak commented 1 month ago

the TileDB-Py dev branch always targets stable releases, with the current one being 2.25.0. The fix should remain in its current branch since it is the only one that builds against 2.26.0

In that case I'll use your branch for TileDB-Py in my nightly builds

Closed by https://github.com/jdblischak/centralized-tiledb-nightlies/commit/b305f44ff459fcf5000d71e3d5bcd426c39fb4c9