search

TillF / WASA-SED

WASA-SED is a numerical model for simulation hydrological and sediment fluxes from meso-scale catchments (Mueller et al., 2010). This repository contains documentation, sample data set and source code.
Other
14 stars 10 forks source link

Minor adjustments, see commits #55

Closed tpilz closed 6 years ago

tpilz commented 6 years ago

... the model still runs into floating point exception when running in debug mode. However, I am not able to fix the issues.

Furthermore, when using valgrind, hundreds of issues appear regarding the use of uninitialised variables. This concerns, as far as I could tell, parameters which are read from files and only initialised during the (possibly optional) reading. I guess, one should initialise every declared variable to a default value in case it is not needed, i.e. not read from an optional file but still used within (again possibly optional) control structures.

I guess, these are rather (or at least mostly) matters of proper programming style and should actually not cause trouble. However, it would be better to fix these issues to get the debugging process working and avoid undetected side-effects.

TillF commented 6 years ago

I eliminated a couple of uninitialized vars in the last commit, probably this already solves part of the problem.