Closed alicelg99 closed 3 years ago
I fixed some bugs and added the missing "snow_params.ctl". Please update both repos (data and executable) and check which errors persist.
After updating both repos and running again the code, I get : Same notes as before for the files :
The changes are :
snowEnergyCont.out : not NaN anymore for January 2001 we get values different from 0 from day 10. The values are between -0.1E+05 and 0.1E+06 kJ/m2. ✔️
snowCover.out : this is a little bit the same observation but the values 0.10000E+01 are not for the same days. ⁉️ We select the lines concerned :
1 | Output file TC-wise areal fraction of snow cover (-)
2 | Year Day Timestep Subbasin LU TC value
4251 | 2001 20 1 15 1 3 0.10000E+01
4252 | 2001 20 1 15 1 2 0.10000E+01
4253 | 2001 20 1 15 1 1 0.10000E+01
4254 | 2001 20 1 15 2 6 0.10000E+01
4255 | 2001 20 1 15 2 5 0.10000E+01
4257 | 2001 20 1 69 1 3 0.10000E+01
4258 | 2001 20 1 69 1 2 0.10000E+01
4259 | 2001 20 1 69 1 1 0.10000E+01
4260 | 2001 20 1 69 2 6 0.10000E+01
4261 | 2001 20 1 69 2 5 0.10000E+01
4263 | 2001 21 1 15 1 3 0.10000E+01
4265 | 2001 21 1 15 1 1 0.10000E+01
4269 | 2001 21 1 69 1 3 0.10000E+01
4270 | 2001 21 1 69 1 2 0.10000E+01
4271 | 2001 21 1 69 1 1 0.10000E+01
4275 | 2001 22 1 15 1 3 0.10000E+01
4281 | 2001 22 1 69 1 3 0.10000E+01
snowAlbedo.out : now the changes start from day 10 (on January 2001) this is more consistant. ✔️
_snowstorage.stat : it is okay now, we don't have NaN for 'energy' anymore. ✔️
cloudFrac.out : We get positive values everyday which are between 0 and 1. ✔️
OK, just replying on the still-open topics:
snowTemp.out: "-9999" is a flag for "not available", as snow temperature cannot be computed when there is no snow. However, its treatment was somewhat inconsistent, as it sometimes was zero, sometimes -9999. Will be fixed in upcoming release. I also refined the formatting of the output, so you may have to re-run the other cases, too, to be consistent.
snow_storage.stat_start : All the values are equal to 0 --> is ok, when the model has no snow at the start.
snowCover.out : The snow cover can range from 0 to 1, so all values within this range should be ok
Reopen the issue, if you feel something still needs to be treated.
The case 15 is the case where the snow mode is on. That means some out files are specific to this case. I will write what I have noticed when going through these files. For some we get strange results that is why I create an 'Issue'. First, it is important to notice that I changed the temperatures for January 2001 into the time series file temperature.dat. The data are :
Now, let see what we found into the files:
snowWaterEquiv.out : 0 everywhere except for January 2001 where we get positive values. Each day the values are different.
snowTemp.out : We get 0°C everywhere but sometimes we have -0.99990E+04 °C. This is strange.
snowEnergyCont.out : We have 0 kJ/m2 everywhere except for January 2001 where we get NaN. Is there a reason for that?
snowCover.out : We get 0 everywhere except for some days and sub-basin during January 2001 where we get 0.10000E+01 :
snowAlbedo.out : Every days we get 0.88 except from the 4th of January 2001 where the values are different each day but lower than 0.88. Why do the changes start from the 4th of January?
_snow_storage.statstart : All the values are equal to 0.
_snowstorage.stat : We get values for the columns 'storage' and 'albedo' but NaN for 'energy'. This is consistent with what we saw in the previous files.
cloudFrac.out : We get NaN every day. Is that normal?