Closed bsell93 closed 5 months ago
Thank you for adding this feature. I only had a quick glance at the PR. Since I currently don't have a lot of free time, a proper review and testing will have to wait (sorry :/).
@TillFleisch no worries! I'm happy to make an attempt at contributing 😃
The readme should be updated with the new configuration options
Yep - good call (Edit: Done)
The min/max angle should have a margin (like max distance) to prevent flickering on the edges
I'm actively using this and not seeing any flickering. If we did see a need to add margin I would definitely go the route of making a separate margin for angle rather than re-using distance.
maybe there is some room for consolidation: the min/max distance/angle seem repetitive. Having a single modular number class (and file) would probably be better (I will look into this once I find the time...)
I was literally thinking the same thing when I was writing it, but for the sake of making it work and reducing chance of failure I just duplicated. Very open to this modification though
I look over this and added some things, I felt were necessary:
I will look over this once more later today. Feel free to play around/find bugs/criticize
Edit: the config could also be consolidated further. The max distance and angles could be covered by a single schema, which has a type attribute to determine which action is intended. This would break existing configs though...
Thank you @bsell93 for adding this feature! :)
Thank you @bsell93 for adding this feature! :)
Thanks for helping me get it across the finish line ☺️
This gives the ability to control max/min value of the angles detected - similar to how "Max Distance" works.
Defaults to -60 to 60deg, which I believe is max detection range; controls are optional.