Filter out copyright-claimed songs

Tillerino commented 6 years ago

Songs that can no longer be downloaded due to a copyright-claim should not be recommended.

Example: https://osu.ppy.sh/b/59311

omkelderman commented 6 years ago

small sidenote, if I already have the song, it would still work 🤔

SlowLogicBoy commented 5 years ago

Even if you can already have copyrighted song, or obtain them some way, it would be nice to have a setting to opt out from getting recommendations of copyrighted songs, because some don't have those songs or want to comply with the laws. On another hand I guess it's fine to recommend copyrighted song since user can do !r again for another recommendation unless !r adds significant load on TillerinoBot. However it might not be as user friendly as I would like, since by clicking on the song to download it, it redirects to DMCA page (just like in an example link), so maybe at least Tillerino could write DMCA or Song no longer available to download along side song title?

Tillerino commented 5 years ago

That should be easy. Is this information somehow obtainable through the API?

On Sat, Dec 1, 2018, 13:20 Simonas G notifications@github.com wrote:

Even if you can already have copyrighted song, or obtain them some way, it would be nice to have a setting to opt out from getting recommendations of copyrighted songs, because some don't have those songs or want to comply with the laws. On another hand I guess it's fine to recommend copyrighted song since user can do !r again for another recommendation unless !r adds significant load on TillerinoBot. However it might not be as user friendly as I would like, since by clicking on the song to download it, it redirects to DMCA page (just like in an example link), so maybe at least Tillerino could write DMCA or Song no longer available to download along side song title?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tillerino/Tillerinobot/issues/154#issuecomment-443422293, or mute the thread https://github.com/notifications/unsubscribe-auth/ABL9ZayJTcDCjLMgteYt_DEKoZgq2-n1ks5u0nPzgaJpZM4QOasl .

SlowLogicBoy commented 5 years ago

Unfortunately I haven't found a way yet to obtain that information :/ without going to beatmap page.

omkelderman commented 5 years ago

api v2 has this section

"availability": {
    "download_disabled": true,
    "more_information": "https://gist.githubusercontent.com/peppy/99e6959772083cdfde8a/raw"
},

but v2 is not production ready and stuff might change without notice, theres no known rate limits, and you have zero support

omkelderman commented 5 years ago

that was in the response body of "https://osu.ppy.sh/api/v2/beatmapsets/15630" btw, aka its set-info, not beatmap info, but that makes sense tbh

Tillerino commented 5 years ago

Can we use ppy/osu-api#241 for this?

Tillerino / Tillerinobot

Filter out copyright-claimed songs #154